fix(react): make instructions elements ids unique #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/codesandbox/sandpack/65Bz5DJDHfiz7BpsPuvKQpyEssMU |
danilowoz
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
The instructions elements ids in each code block must be unique, otherwise you will get the following HTML errors if you use more than one code block on web page:
What is the current behavior?
When I try to check the site with the W3C Validator, I get the "Duplicate ID" errors (see https://validator.w3.org/nu/?doc=https%3A%2F%2Fbeta.reactjs.org%2Flearn for example).
What is the new behavior?
No any "Duplicate ID" errors when validator checks web page that contains multiple code blocks.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist